Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Dev] Prune .dockerignore #43969

Closed
pitrou opened this issue Sep 5, 2024 · 2 comments
Closed

[CI][Dev] Prune .dockerignore #43969

pitrou opened this issue Sep 5, 2024 · 2 comments
Assignees
@pitrou
Labels
Component: Continuous Integration Component: Developer Tools Type: enhancement
Milestone
18.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Sep 5, 2024

Describe the enhancement requested

The .dockerignore file governs which files are sent in the "build context" of a Docker image, which in turn impacts Docker caching.

Our .dockerignore file seems to have a lot of stale entries. Also, some of them seem dubious (why include dev/archery/setup.py if you don't include Archery's source tree, for example?).

Component(s)

Continuous Integration, Developer Tools
@pitrou
Copy link
Member Author

pitrou commented Sep 5, 2024

cc @kou

pitrou added a commit to pitrou/arrow that referenced this issue Sep 5, 2024
@pitrou
apacheGH-43969: [CI][Dev] Prune .dockerignore
c9078bc
pitrou added a commit to pitrou/arrow that referenced this issue Sep 5, 2024
@pitrou
apacheGH-43969: [CI][Dev] Prune .dockerignore
f3c8790
@github-actions github-actions bot mentioned this issue Sep 5, 2024
Merged
pitrou added a commit to pitrou/arrow that referenced this issue Sep 5, 2024
@pitrou
apacheGH-43969: [CI][Dev] Prune .dockerignore
1cf73ad
pitrou added a commit that referenced this issue Sep 5, 2024
@pitrou
GH-43969: [CI][Dev] Prune .dockerignore (#43971)
7a24729 
### Rationale for this change

The smaller the better, according to https://docs.docker.com/build/cache/optimize/

### What changes are included in this PR?

Prune obsolete or unnecessary inclusions from `.dockerignore`.

### Are these changes tested?

Yes, by CI.

### Are there any user-facing changes?

No.

* GitHub Issue: #43969

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
@pitrou pitrou added this to the 18.0.0 milestone Sep 5, 2024
@pitrou
Copy link
Member Author

pitrou commented Sep 5, 2024

Issue resolved by pull request 43971
#43971

@pitrou pitrou closed this as completed Sep 5, 2024
zanmato1984 pushed a commit to zanmato1984/arrow that referenced this issue Sep 6, 2024
@pitrou @zanmato1984
apacheGH-43969: [CI][Dev] Prune .dockerignore (apache#43971)
0d77167 
### Rationale for this change

The smaller the better, according to https://docs.docker.com/build/cache/optimize/

### What changes are included in this PR?

Prune obsolete or unnecessary inclusions from `.dockerignore`.

### Are these changes tested?

Yes, by CI.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#43969

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@pitrou @khwilson
apacheGH-43969: [CI][Dev] Prune .dockerignore (apache#43971)
97172b6 
### Rationale for this change

The smaller the better, according to https://docs.docker.com/build/cache/optimize/

### What changes are included in this PR?

Prune obsolete or unnecessary inclusions from `.dockerignore`.

### Are these changes tested?

Yes, by CI.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#43969

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: Continuous Integration Component: Developer Tools Type: enhancement
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
1 participant
@pitrou