Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Check for nullabilities when comparing StructVector #43966

Closed
hellishfire opened this issue Sep 5, 2024 · 4 comments
Closed

[Java] Check for nullabilities when comparing StructVector #43966

hellishfire opened this issue Sep 5, 2024 · 4 comments
Assignees
@hellishfire
Labels
Component: Java Type: bug
Milestone
18.0.0

Comments

@hellishfire
Copy link
Contributor

Describe the bug, including details regarding any error messages, version, and platform.

Currently RangeEqualsVisitor doesn't consider the nullabilities of StructVector, thus it may incorrectly reports true when two StructVector have same underlying field vectors but differ in struct nullabilities.

Component(s)

Java
@vibhatha
Copy link
Collaborator

vibhatha commented Sep 5, 2024

@hellishfire thanks for reporting this, would it be possible to provide a reproducible test case or an example?

@hellishfire
Copy link
Contributor Author

@hellishfire thanks for reporting this, would it be possible to provide a reproducible test case or an example?

I'll submit a fix along with simple tests shortly.

@vibhatha
Copy link
Collaborator

vibhatha commented Sep 5, 2024

Wonderful, thanks.

@hellishfire hellishfire mentioned this issue Sep 5, 2024
Merged
@hellishfire hellishfire changed the title [Java] RangeEqualsVisitor doesn't consider nullabilities when comparing StructVector [Java] Check for nullabilities when comparing StructVector Sep 5, 2024
lidavidm pushed a commit that referenced this issue Sep 9, 2024
@hellishfire
GH-43966: [Java] Check for nullabilities when comparing StructVector (#…
d0f9f3e 
…43968)

### Rationale for this change

See #43966

### What changes are included in this PR?

Check for nullabilities when comparing StructVector with RangeEqualsVisitor.

### Are these changes tested?

Yes

### Are there any user-facing changes?
No

* GitHub Issue: #43966

Authored-by: youming.whl <[email protected]>
Signed-off-by: David Li <[email protected]>
@lidavidm lidavidm added this to the 18.0.0 milestone Sep 9, 2024
@lidavidm
Copy link
Member

lidavidm commented Sep 9, 2024

Issue resolved by pull request 43968
#43968

@lidavidm lidavidm closed this as completed Sep 9, 2024
khwilson pushed a commit to khwilson/arrow that referenced this issue Sep 14, 2024
@hellishfire @khwilson
apacheGH-43966: [Java] Check for nullabilities when comparing StructV…
38b3770 
…ector (apache#43968)

### Rationale for this change

See apache#43966

### What changes are included in this PR?

Check for nullabilities when comparing StructVector with RangeEqualsVisitor.

### Are these changes tested?

Yes

### Are there any user-facing changes?
No

* GitHub Issue: apache#43966

Authored-by: youming.whl <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hellishfire hellishfire

Labels
Component: Java Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
3 participants
@lidavidm @hellishfire @vibhatha