Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][Dev][Release] CI jobs for Source Release and Merge Script are failing after bumping versions #43284

Closed
raulcd opened this issue Jul 16, 2024 · 3 comments
Closed

[CI][Dev][Release] CI jobs for Source Release and Merge Script are failing after bumping versions #43284

raulcd opened this issue Jul 16, 2024 · 3 comments
Assignees
@raulcd
Labels
Component: Continuous Integration Component: Developer Tools Component: Release Type: bug
Milestone
18.0.0

Comments

@raulcd
Copy link
Member

raulcd commented Jul 16, 2024

Describe the bug, including details regarding any error messages, version, and platform.

After executing the bump-versions script after the release, which generates the following two commits:
55ce352
18319d3

The Source Release and Merge Script CI jobs are failing with:

PostBumpVersionsTest: 
  test_deb_package_names[bump_type: nil]:		E
===============================================================================
Error: test_deb_package_names[bump_type: nil](PostBumpVersionsTest):
  CommandRunnable::Error: Failed to run: dev/release/post-12-bump-versions.sh 18.0.0 19.0.0
  stdout:
   Updating .deb package names for 19.0.0
  /private/var/folders/xz/lz5thm6s3vb1vdkk77vmkgbr0000gn/T/d20240716-2671-jtxceq/arrow/dev/tasks/linux-packages/apache-arrow /private/var/folders/xz/lz5thm6s3vb1vdkk77vmkgbr0000gn/T/d20240716-2671-jtxceq/arrow
  
  stderr:
   fatal: bad source, source=dev/tasks/linux-packages/apache-arrow/debian*/lib*1800.install, destination=dev/tasks/linux-packages/apache-arrow/debian*/lib*1900.install
/Users/runner/work/arrow/arrow/dev/release/test-helper.rb:47:in `sh'
/Users/runner/work/arrow/arrow/dev/release/post-12-bump-versions-test.rb:70:in `bump_versions'
/Users/runner/work/arrow/arrow/dev/release/post-12-bump-versions-test.rb:361:in `test_deb_package_names'
     358:   def test_deb_package_names
     359:     omit_on_release_branch unless bump_type.nil?
     360:     current_commit = git_current_commit
  => 361:     stdout = bump_versions("DEB_PACKAGE_NAMES")
     362:     changes = parse_patch(git("log", "-p", "#{current_commit}.."))
     363:     sampled_changes = changes.collect do |change|
     364:       first_hunk = change[:hunks][0]
/Users/runner/work/arrow/arrow/dev/release/post-12-bump-versions-test.rb:35:in `block (2 levels) in setup'
/Users/runner/work/arrow/arrow/dev/release/post-12-bump-versions-test.rb:31:in `chdir'
/Users/runner/work/arrow/arrow/dev/release/post-12-bump-versions-test.rb:31:in `block in setup'
/Users/runner/hostedtoolcache/Ruby/3.3.4/arm64/lib/ruby/3.3.0/tmpdir.rb:99:in `mktmpdir'
/Users/runner/work/arrow/arrow/dev/release/post-12-bump-versions-test.rb:28:in `setup'
===============================================================================
: (1.953008)
  test_deb_package_names[bump_type: :minor]:		.: (1.839936)
  test_deb_package_names[bump_type: :patch]:		.: (1.782844)
  test_linux_packages:					.: (2.743860)
  test_version_post_tag[next_release_type: :major]:	.: (23.563749)
  test_version_post_tag[next_release_type: :minor]:	.: (17.358402)
  test_version_post_tag[next_release_type: :patch]:	.: (17.056213)
PrepareTest: 
  test_deb_package_names[release_type: nil]:		.: (2.173847)
  test_deb_package_names[release_type: :major]:		E
===============================================================================
Error: test_deb_package_names[release_type: :major](PrepareTest):
  CommandRunnable::Error: Failed to run: dev/release/01-prepare.sh 19.0.0 20.0.0 0
  stdout:
   Updating .deb package names for 19.0.0
  /private/var/folders/xz/lz5thm6s3vb1vdkk77vmkgbr0000gn/T/d20240716-2671-bnthe2/arrow/dev/tasks/linux-packages/apache-arrow /private/var/folders/xz/lz5thm6s3vb1vdkk77vmkgbr0000gn/T/d20240716-2671-bnthe2/arrow
  
  stderr:
   fatal: bad source, source=dev/tasks/linux-packages/apache-arrow/debian*/lib*1800.install, destination=dev/tasks/linux-packages/apache-arrow/debian*/lib*1900.install
/Users/runner/work/arrow/arrow/dev/release/test-helper.rb:47:in `sh'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:51:in `prepare'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:58:in `test_deb_package_names'
     55:   def test_deb_package_names
     56:     omit_on_release_branch
     57:     current_commit = git_current_commit
  => 58:     stdout = prepare("DEB_PACKAGE_NAMES")
     59:     changes = parse_patch(git("log", "-p", "#{current_commit}.."))
     60:     sampled_changes = changes.collect do |change|
     61:       first_hunk = change[:hunks][0]
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:34:in `block (2 levels) in setup'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:31:in `chdir'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:31:in `block in setup'
/Users/runner/hostedtoolcache/Ruby/3.3.4/arm64/lib/ruby/3.3.0/tmpdir.rb:99:in `mktmpdir'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:28:in `setup'
===============================================================================
: (2.088267)
  test_deb_package_names[release_type: :minor]:		E
===============================================================================
Error: test_deb_package_names[release_type: :minor](PrepareTest):
  CommandRunnable::Error: Failed to run: dev/release/01-prepare.sh 18.1.0 19.0.0 0
  stdout:
   Updating .deb package names for 18.1.0
  /private/var/folders/xz/lz5thm6s3vb1vdkk77vmkgbr0000gn/T/d20240716-2671-us0rjr/arrow/dev/tasks/linux-packages/apache-arrow /private/var/folders/xz/lz5thm6s3vb1vdkk77vmkgbr0000gn/T/d20240716-2671-us0rjr/arrow
  
  stderr:
   fatal: bad source, source=dev/tasks/linux-packages/apache-arrow/debian*/lib*1800.install, destination=dev/tasks/linux-packages/apache-arrow/debian*/lib*1801.install
/Users/runner/work/arrow/arrow/dev/release/test-helper.rb:47:in `sh'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:51:in `prepare'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:58:in `test_deb_package_names'
     55:   def test_deb_package_names
     56:     omit_on_release_branch
     57:     current_commit = git_current_commit
  => 58:     stdout = prepare("DEB_PACKAGE_NAMES")
     59:     changes = parse_patch(git("log", "-p", "#{current_commit}.."))
     60:     sampled_changes = changes.collect do |change|
     61:       first_hunk = change[:hunks][0]
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:34:in `block (2 levels) in setup'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:31:in `chdir'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:31:in `block in setup'
/Users/runner/hostedtoolcache/Ruby/3.3.4/arm64/lib/ruby/3.3.0/tmpdir.rb:99:in `mktmpdir'
/Users/runner/work/arrow/arrow/dev/release/01-prepare-test.rb:28:in `setup'

Component(s)

Continuous Integration, Developer Tools, Release
@raulcd raulcd mentioned this issue Jul 16, 2024
Merged
@kou
Copy link
Member

kou commented Jul 17, 2024

Hmm. Do you have the "MINOR: [Release] Update .deb package names for 18.0.0" commit like e37b2ac on local? If you have it, could you push it to the main branch?

raulcd added a commit to raulcd/arrow that referenced this issue Jul 17, 2024
@raulcd
apacheGH-43284: [Release] Fix variable name on post-12-bump-versions.…
9eb3d40 
…sh script
@github-actions github-actions bot mentioned this issue Jul 17, 2024
Merged
@raulcd
Copy link
Member Author

raulcd commented Jul 17, 2024

It seems this: #41859 introduced an issue on the post-12-bump-versions.sh script. I've created a PR and have used the change to push c66b3f1

kou pushed a commit that referenced this issue Jul 20, 2024
@raulcd
GH-43284: [Release] Fix version detection timing for bump deb package…
fe51029 
… names on post-12-bump-versions.sh script (#43294)

### Rationale for this change

The script fails to bump deb package names at the moment due to an unmatching if.

### What changes are included in this PR?

Use current_version before bumping the versions in order to match debian packages to be updated.

### Are these changes tested?

It has been tested locally to bump the versions for the debian package names on main for 17.0.0

### Are there any user-facing changes?

No
* GitHub Issue: #43284

Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 18.0.0 milestone Jul 20, 2024
@kou
Copy link
Member

kou commented Jul 20, 2024

Issue resolved by pull request 43294
#43294

@kou kou closed this as completed Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@raulcd raulcd

Labels
Component: Continuous Integration Component: Developer Tools Component: Release Type: bug
Projects
None yet
Milestone
18.0.0
Development

No branches or pull requests
2 participants
@kou @raulcd