Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Packaging][RPM] Mismatch between package version and library version in naming #41784

Closed
daeden opened this issue May 22, 2024 · 2 comments
Closed

Comments

@daeden
Copy link

daeden commented May 22, 2024

Describe the bug, including details regarding any error messages, version, and platform.

Version: 16.1.0

Platform: Red Hat Enterprise Linux release 9.4 (Plow)

Summary: The version number in the library name does not match the version of the package that is installed. This causes load time issues where we fail to find library dependencies even when version mismatch is only on minor version change, which should backwards compatible.

Steps to Reproduce:

  1. Install the package for version 16.1.0
  2. List the installed libraries (ls /lib64/libarrow.so*)

Expected Result: The libraries should be labeled with the correct version number (16.1.0) with symlinks for major version and non versioned.

For example, I would expect to find:

$ ls  /lib64/libarrow.so*
/lib64/libarrow.so@  /lib64/libarrow.so.16@  /lib64/libarrow.so.16.1.0*

Actual Result: The libraries are labeled with an incorrect version number (1601.0.0)

$ ls  /lib64/libarrow.so*
/lib64/libarrow.so@  /lib64/libarrow.so.1601@  /lib64/libarrow.so.1601.0.0*

Component(s)

Packaging

@kou kou changed the title Mismatch between package version and library version in naming [Packaging][RPM] Mismatch between package version and library version in naming May 23, 2024
@kou
Copy link
Member

kou commented May 23, 2024

We should use libarrow1601-libs and so on not libarrow16-libs for 16.1.X.
Related: #41679

kou added a commit that referenced this issue May 28, 2024
)

### Rationale for this change

We should use `arrow${SO_VERSION}-libs` not `arrow${MAJOR_VERSION}-libs` to co-exist newer versions and older versions.

### What changes are included in this PR?

Use SO version not major version.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: #41784

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou kou added this to the 17.0.0 milestone May 28, 2024
@kou
Copy link
Member

kou commented May 28, 2024

Issue resolved by pull request 41838
#41838

@kou kou closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants