Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Swift] Implement FFI support #37938

Closed
sunchao opened this issue Sep 28, 2023 · 7 comments
Closed

[Swift] Implement FFI support #37938

sunchao opened this issue Sep 28, 2023 · 7 comments
Assignees
@abandy
Labels
Component: Swift Type: enhancement
Milestone
17.0.0

Comments

@sunchao
Copy link
Member

sunchao commented Sep 28, 2023

Describe the enhancement requested

Since we already have basic implementations for Arrow buffer, array, data type etc, in Swift. It would be great if we can implement the Arrow C Data Interface in Swift, so that Arrow arrays in other languages such as Rust, C++, can be easily imported into Swift and operated on.

Component(s)

Swift
@sunchao
Copy link
Member Author

sunchao commented Sep 28, 2023

cc @abandy @viirya

@viirya
Copy link
Member

viirya commented Sep 28, 2023

Yea, I think this is nice to have.

@abandy
Copy link
Contributor

abandy commented Oct 9, 2023

This would be great. I will start looking into the C Data Interface and the Swift impl.

@abandy
Copy link
Contributor

abandy commented Nov 8, 2023

Please assign this task to me as I am starting on this work.

@viirya
Copy link
Member

viirya commented Nov 8, 2023

Thank you @abandy

abandy added a commit to abandy/arrow that referenced this issue Dec 6, 2023
@abandy
apacheGH-37938:[Swift] initial impl of C Data interface
6ea3b00
@github-actions github-actions bot mentioned this issue Dec 6, 2023
Closed
abandy added a commit to abandy/arrow that referenced this issue Jan 8, 2024
@abandy
apacheGH-37938:[Swift] fix null count when using reader
25d789c
@github-actions github-actions bot mentioned this issue Jan 8, 2024
Merged
abandy added a commit to abandy/arrow that referenced this issue Feb 5, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
092e98e
abandy added a commit to abandy/arrow that referenced this issue Feb 5, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
37f7c64
abandy added a commit to abandy/arrow that referenced this issue Feb 5, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
67ad721
abandy added a commit to abandy/arrow that referenced this issue Feb 5, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
58830c3
abandy added a commit to abandy/arrow that referenced this issue Feb 5, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
4361165
abandy added a commit to abandy/arrow that referenced this issue Feb 5, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
0eae75a
abandy added a commit to abandy/arrow that referenced this issue Feb 7, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
a1404c4
abandy added a commit to abandy/arrow that referenced this issue Feb 8, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
b64e0a1
abandy added a commit to abandy/arrow that referenced this issue Feb 8, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
4af0150
abandy added a commit to abandy/arrow that referenced this issue Feb 16, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
a8166fe
abandy added a commit to abandy/arrow that referenced this issue Feb 17, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
a4a0c7c
@abandy
Copy link
Contributor

abandy commented Mar 29, 2024

Closed my PR due to taking to long to get feedback. I opened the PR for the initial checkin in early December and it is still outstanding with comments slowly trickling in. Removing myself from this issue so someone else can pick it up and hopefully get better support.

@abandy abandy removed their assignment Mar 29, 2024
abandy added a commit to abandy/arrow that referenced this issue Apr 2, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
76dd161
abandy added a commit to abandy/arrow that referenced this issue Apr 22, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
8bc079a
abandy added a commit to abandy/arrow that referenced this issue Apr 22, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
2ed8281
abandy added a commit to abandy/arrow that referenced this issue Apr 22, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
5c73e0a
abandy added a commit to abandy/arrow that referenced this issue Apr 22, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
5df4c6c
@github-actions github-actions bot mentioned this issue Apr 23, 2024
Merged
abandy added a commit to abandy/arrow that referenced this issue Apr 23, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
8a9e1e8
abandy added a commit to abandy/arrow that referenced this issue Apr 23, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
22281f7
abandy added a commit to abandy/arrow that referenced this issue Apr 23, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
461cf90
abandy added a commit to abandy/arrow that referenced this issue Apr 23, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
453cf4f
abandy added a commit to abandy/arrow that referenced this issue Apr 24, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
739c452
abandy added a commit to abandy/arrow that referenced this issue Apr 24, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
c269261
abandy added a commit to abandy/arrow that referenced this issue Apr 24, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
7d2591e
abandy added a commit to abandy/arrow that referenced this issue Apr 28, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
dc1534d
abandy added a commit to abandy/arrow that referenced this issue May 3, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
2d99636
abandy added a commit to abandy/arrow that referenced this issue May 18, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
afc1c13
abandy added a commit to abandy/arrow that referenced this issue May 24, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
869898c
abandy added a commit to abandy/arrow that referenced this issue May 28, 2024
@abandy
apacheGH-37938: [Swift] initial impl of C Data interface
bf12256
kou pushed a commit that referenced this issue May 29, 2024
@abandy
GH-37938: [Swift] Add initial C data interface implementation (#41342)
4d524eb 
Continuation for PR: #39091

This add an initial implementation of the C Data interface for swift. During development it was found that null count was not being properly maintained on the arrow buffers and this change is included as well. Also some minor refactoring was done to existing sources to enable this feature.

This has been tested from Swift calling into C to import data but not from Swift to C exporting data. Test is currently ongoing.
* GitHub Issue: #37938

Authored-by: Alva Bandy <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
@kou
Copy link
Member

kou commented May 29, 2024

Issue resolved by pull request 41342
#41342

@kou kou added this to the 17.0.0 milestone May 29, 2024
@kou kou closed this as completed May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abandy abandy

Labels
Component: Swift Type: enhancement
Projects
None yet
Milestone
17.0.0
Development

Successfully merging a pull request may close this issue.

GH-37938: [Swift] initial impl of C Data interface abandy/arrow
4 participants
@kou @viirya @sunchao @abandy