Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI][C++] Enable S3 in Valgrind build #36556

Closed
pitrou opened this issue Jul 7, 2023 · 2 comments · Fixed by #36579
Closed

[CI][C++] Enable S3 in Valgrind build #36556

pitrou opened this issue Jul 7, 2023 · 2 comments · Fixed by #36579
Assignees
@pitrou
Labels
Component: C++ Component: Continuous Integration Type: enhancement
Milestone
13.0.0

Comments

@pitrou
Copy link
Member

pitrou commented Jul 7, 2023

Describe the enhancement requested

Our Valgrind C++ build (conda-cpp-valgrind) currently has ARROW_S3=OFF.

It would be nice to enable S3 in that build for better coverage. However, we need to bump the AWS SDK to a more recent version (at least 1.11.62, it seems) to avoid false positives.

Component(s)

C++, Continuous Integration
@pitrou
Copy link
Member Author

pitrou commented Jul 7, 2023

@kou @raulcd FYI

@pitrou
Copy link
Member Author

pitrou commented Jul 9, 2023

We should be able to do this now that #36557 is in.

@pitrou pitrou self-assigned this Jul 9, 2023
pitrou added a commit to pitrou/arrow that referenced this issue Jul 9, 2023
@pitrou
apacheGH-36556: [CI][C++] Enable S3 in Valgrind build
2cb6d0e
@github-actions github-actions bot mentioned this issue Jul 9, 2023
Merged
@kou kou closed this as completed in #36579 Jul 9, 2023
@kou kou added this to the 13.0.0 milestone Jul 9, 2023
kou pushed a commit that referenced this issue Jul 9, 2023
@pitrou
GH-36556: [CI][C++] Enable S3 in Valgrind build (#36579)
d9f6e0e 
* Closes: #36556

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pitrou pitrou

Labels
Component: C++ Component: Continuous Integration Type: enhancement
Projects
None yet
Milestone
13.0.0
Development

Successfully merging a pull request may close this issue.

GH-36556: [CI][C++] Enable S3 in Valgrind build pitrou/arrow
2 participants
@kou @pitrou