Skip to content

Commit

Permalink
ARROW-17742: [C++][Gandiva] Fix Gandiva utf8proc dependency in CMake …
Browse files Browse the repository at this point in the history
…presets (#14140)

Building CMake presets `ninja-release-gandiva` and `ninja-debug-gandiva` fails with a link error saying utf8proc related definitions are not found. It's because `ARROW_WITH_UTF8PROC` is explicitly turned off in these two presets but is required to build Gandiva.

Add `set(ARROW_WITH_UTF8PROC ON)` if `ARROW_GANDIVA` solves the issue. An alternative solution is to enable `ARROW_WITH_UTF8PROC` in the preset settings. But I think the current solution is more general.

Authored-by: Jin Shang <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
js8544 authored Sep 15, 2022
1 parent bced07d commit e63a13a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -333,6 +333,7 @@ endif()

if(ARROW_GANDIVA)
set(ARROW_WITH_RE2 ON)
set(ARROW_WITH_UTF8PROC ON)
endif()

if(ARROW_BUILD_INTEGRATION AND ARROW_FLIGHT)
Expand Down

0 comments on commit e63a13a

Please sign in to comment.