Skip to content

Commit

Permalink
add a note about lazy stopping but don't test it quite yet
Browse files Browse the repository at this point in the history
  • Loading branch information
paleolimbot committed Aug 31, 2022
1 parent 5ff736d commit c99fd56
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions r/tests/testthat/test-query-engine.R
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,9 @@ test_that("ExecPlanReader evaluates head() lazily", {
query <- head(as_adq(reader), 10)
expect_identical(as_arrow_table(query)$num_rows, 10L)

# make sure there are some rows left
expect_true(reader$read_table()$num_rows > 0)
# Depending on exactly how quickly background threads respond to the
# request to cancel, reader$read_table()$num_rows > 0 may or may not
# evaluate to TRUE (i.e., the reader may or may not be completely drained).
})

test_that("do_exec_plan_substrait can evaluate a simple plan", {
Expand Down

0 comments on commit c99fd56

Please sign in to comment.