GH-44700: [C++][Parquet] Remove obsolete parquet_constants generated …

…files from old thrift (#44772) ### Rationale for this change The files were generated 4 years ago with and old version of Thrift and don't seem necessary anymore. ### What changes are included in this PR? Remove obsolete files. ### Are these changes tested? No new tests added, just validate tests pass. ### Are there any user-facing changes? No * GitHub Issue: #44700 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
apache · Nov 19, 2024 · 9d19450 · 9d19450
1 parent 6134b2e
commit 9d19450
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 48 deletions.
diff --git a/cpp/build-support/lint_exclusions.txt b/cpp/build-support/lint_exclusions.txt
@@ -3,7 +3,6 @@
 *RcppExports.cpp*
 *_generated*
 *arrowExports.cpp*
-*parquet_constants.*
 *parquet_types.*
 *pyarrow_api.h
 *pyarrow_lib.h

diff --git a/cpp/src/generated/parquet_constants.cpp b/cpp/src/generated/parquet_constants.cpp
diff --git a/cpp/src/generated/parquet_constants.h b/cpp/src/generated/parquet_constants.h
diff --git a/cpp/src/parquet/CMakeLists.txt b/cpp/src/parquet/CMakeLists.txt
@@ -140,8 +140,6 @@ set(PARQUET_THRIFT_SOURCE_DIR "${ARROW_SOURCE_DIR}/src/generated/")
 
 set_source_files_properties("${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp"
                             "${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.h"
-                            "${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
-                            "${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.h"
                             PROPERTIES SKIP_PRECOMPILE_HEADERS ON
                                        SKIP_UNITY_BUILD_INCLUSION ON)
 
@@ -178,7 +176,6 @@ set(PARQUET_SRCS
     metadata.cc
     xxhasher.cc
     page_index.cc
-    "${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
     "${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp"
     platform.cc
     printer.cc
@@ -307,7 +304,6 @@ add_arrow_lib(parquet
 
 if(WIN32 AND NOT (ARROW_TEST_LINKAGE STREQUAL "static"))
   add_library(parquet_test_support STATIC
-              "${PARQUET_THRIFT_SOURCE_DIR}/parquet_constants.cpp"
               "${PARQUET_THRIFT_SOURCE_DIR}/parquet_types.cpp")
   target_link_libraries(parquet_test_support thrift::thrift)
   list(PREPEND PARQUET_TEST_LINK_LIBS parquet_test_support)

diff --git a/dev/release/rat_exclude_files.txt b/dev/release/rat_exclude_files.txt
@@ -25,8 +25,6 @@ cpp/build-support/iwyu/*
 cpp/cmake_modules/FindPythonLibsNew.cmake
 cpp/examples/parquet/parquet-arrow/cmake_modules/FindArrow.cmake
 cpp/src/parquet/.parquetcppversion
-cpp/src/generated/parquet_constants.cpp
-cpp/src/generated/parquet_constants.h
 cpp/src/generated/parquet_types.cpp
 cpp/src/generated/parquet_types.h
 cpp/src/generated/substrait/*