Skip to content

Commit

Permalink
MINOR: [C++] ARROW_TESTING implies ARROW_JSON (#14054)
Browse files Browse the repository at this point in the history
Otherwise a minimal build fails with errors like

```
CMake Error at cmake_modules/BuildUtils.cmake:272 (target_link_libraries):
  Target "arrow_testing_objlib" links to:

    rapidjson::rapidjson

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

Call Stack (most recent call first):
  src/arrow/CMakeLists.txt:653 (add_arrow_lib)
```

Authored-by: David Li <[email protected]>
Signed-off-by: David Li <[email protected]>
  • Loading branch information
lidavidm authored Sep 8, 2022
1 parent 2920d52 commit 8fe7e35
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,6 @@ if(ARROW_BUILD_BENCHMARKS
OR ARROW_BUILD_TESTS
OR ARROW_BUILD_INTEGRATION
OR ARROW_FUZZING)
set(ARROW_JSON ON)
set(ARROW_TESTING ON)
endif()

Expand Down Expand Up @@ -366,6 +365,10 @@ if(ARROW_SKYHOOK)
set(ARROW_WITH_SNAPPY ON)
endif()

if(ARROW_TESTING)
set(ARROW_JSON ON)
endif()

if(ARROW_DATASET)
set(ARROW_COMPUTE ON)
set(ARROW_FILESYSTEM ON)
Expand Down

0 comments on commit 8fe7e35

Please sign in to comment.