reflect review feedback on exception handling

apache · Jun 18, 2024 · 323c709 · 323c709
1 parent 4ea9178
commit 323c709
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/...ache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat4VectorAccessorTest.java b/...ache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat4VectorAccessorTest.java
@@ -189,11 +189,7 @@ public void testShouldGetBigDecimalMethodFromFloat4Vector() throws Exception {
         (accessor, currentRow) -> {
           float value = accessor.getFloat();
           if (Float.isInfinite(value) || Float.isNaN(value)) {
-            assertThrows(
-                SQLException.class,
-                () -> {
-                  throw new SQLException();
-                });
+            assertThrows(SQLException.class, accessor::getBigDecimal);
           } else {
             assertThat(accessor.getBigDecimal(), is(BigDecimal.valueOf(value)));
           }
@@ -207,11 +203,7 @@ public void testShouldGetBigDecimalWithScaleMethodFromFloat4Vector() throws Exce
         (accessor, currentRow) -> {
           float value = accessor.getFloat();
           if (Float.isInfinite(value) || Float.isNaN(value)) {
-            assertThrows(
-                SQLException.class,
-                () -> {
-                  throw new SQLException();
-                });
+            assertThrows(SQLException.class, () -> accessor.getBigDecimal(9));
           } else {
             assertThat(
                 accessor.getBigDecimal(9),

diff --git a/...ache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat8VectorAccessorTest.java b/...ache/arrow/driver/jdbc/accessor/impl/numeric/ArrowFlightJdbcFloat8VectorAccessorTest.java
@@ -142,11 +142,7 @@ public void testShouldGetBigDecimalMethodFromFloat8Vector() throws Exception {
         (accessor, currentRow) -> {
           double value = accessor.getDouble();
           if (Double.isInfinite(value) || Double.isNaN(value)) {
-            assertThrows(
-                SQLException.class,
-                () -> {
-                  throw new SQLException();
-                });
+            assertThrows(SQLException.class, accessor::getBigDecimal);
           } else {
             assertThat(accessor.getBigDecimal(), is(BigDecimal.valueOf(value)));
           }
@@ -186,11 +182,7 @@ public void testShouldGetBigDecimalWithScaleMethodFromFloat4Vector() throws Exce
         (accessor, currentRow) -> {
           double value = accessor.getDouble();
           if (Double.isInfinite(value) || Double.isNaN(value)) {
-            assertThrows(
-                SQLException.class,
-                () -> {
-                  throw new SQLException();
-                });
+            assertThrows(SQLException.class, () -> accessor.getBigDecimal(9));
           } else {
             assertThat(
                 accessor.getBigDecimal(9),