Fix warnings introduced by Rust/Clippy 1.57.0 #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
Codecov Report
@@ Coverage Diff @@
## master #992 +/- ##
==========================================
- Coverage 82.31% 82.29% -0.02%
==========================================
Files 168 168
Lines 48763 48761 -2
==========================================
- Hits 40139 40128 -11
- Misses 8624 8633 +9
Continue to review full report at Codecov.
|
|
Thanks @carols10cents for the quick fix. Could you run |
carols10cents
force-pushed
the
new-clippy
branch
from
16a5283 to
48b37a5
Compare
houqp
approved these changes
Dec 2, 2021
This was referenced Dec 3, 2021
alamb
pushed a commit
that referenced
this pull request
Dec 4, 2021
* Remove needless borrows identified by clippy https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow * Remove muts that are no longer needed * Derive Default instead of using an equivalent manual impl Identified by clippy. https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls * Remove redundant closures Identified by clippy. https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure * Allow dead code on a field Rust now identifies as never read
alamb
added a commit
that referenced
this pull request
Dec 5, 2021
…elease (#1004) * Fix warnings introduced by Rust/Clippy 1.57.0 (#992) * Remove needless borrows identified by clippy https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow * Remove muts that are no longer needed * Derive Default instead of using an equivalent manual impl Identified by clippy. https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls * Remove redundant closures Identified by clippy. https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure * Allow dead code on a field Rust now identifies as never read * Add some extra drops to make it clear what we want to do Co-authored-by: Carol (Nichols || Goulding) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #991.
Rationale for this change
Upgrading is great! Passing CI is great!
What changes are included in this PR?
I've fixed a number of new warnings. The only one I chose to allow is a new one for a field that's unread, and I'm not sure if that's on purpose or not.
Are there any user-facing changes?
Shouldn't be!