CSV Parser: Infer numbers like 2. as Float64
#950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
approved these changes
Nov 13, 2021
alamb
changed the title
2. as Float64
alamb
changed the title
2. as Float64 2. as Float64
alamb
approved these changes
Nov 13, 2021
alamb
pushed a commit
that referenced
this pull request
Nov 22, 2021
alamb
pushed a commit
that referenced
this pull request
Nov 23, 2021
alamb
added a commit
that referenced
this pull request
Nov 23, 2021
Co-authored-by: Brian Rackle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #929
Rationale for this change
Parsing 2. in a CSV as UTF8 is incorrect since 2. is commonly interpretted as a numeric value. The most straightforward solution is to follow the native item parse capabilities which can only parse 2. as Float.