feat(ipc): Support writing dictionaries nested in structs and unions #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dictionaries are lost when serializing a RecordBatch for IPC, producing invalid arrow data. This PR changes encoded_batch to recursively find all dictionary fields within the schema (currently only in structs and unions) so nested dictionaries are properly serialized.
helgikrs
changed the title
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
==========================================
- Coverage 82.45% 82.43% -0.02%
==========================================
Files 168 168
Lines 48150 48206 +56
==========================================
+ Hits 39700 39741 +41
- Misses 8450 8465 +15
Continue to review full report at Codecov.
|
alamb
approved these changes
Oct 29, 2021
|
|
||
| if let DataType::Dictionary(_key_type, _value_type) = column.data_type() { | ||
| ) -> Result<()> { | ||
| // TODO: Handle other nested types (map, list, etc) |
There was a problem hiding this comment.
might be worth filing another tracking ticket if you have time
alamb
pushed a commit
that referenced
this pull request
Nov 4, 2021
…870) * feat(ipc): Support for writing dictionaries nested in structs and unions Dictionaries are lost when serializing a RecordBatch for IPC, producing invalid arrow data. This PR changes encoded_batch to recursively find all dictionary fields within the schema (currently only in structs and unions) so nested dictionaries are properly serialized. * address lint and clippy
alamb
added a commit
that referenced
this pull request
Nov 5, 2021
…870) (#915) * feat(ipc): Support for writing dictionaries nested in structs and unions Dictionaries are lost when serializing a RecordBatch for IPC, producing invalid arrow data. This PR changes encoded_batch to recursively find all dictionary fields within the schema (currently only in structs and unions) so nested dictionaries are properly serialized. * address lint and clippy Co-authored-by: Helgi Kristvin Sigurbjarnarson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #846
Rationale for this change
Dictionaries are lost when serializing a
RecordBatchfor IPC, producing invalid arrow data. This PR changesencoded_batchto recursively find all dictionary fields within the schema (currently only in structs and unions) so nested dictionaries are properly serialized.