Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests for arrays - via collect method. #785

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Conversation

novemberkilo
Copy link
Contributor

Which issue does this PR close?

Ref #302

Additional doctests to cover creating arrays via the collect method.

// @alamb

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 19, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #785 (6b40e9b) into master (499301c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #785   +/-   ##
=======================================
  Coverage   82.54%   82.54%           
=======================================
  Files         168      168           
  Lines       47912    47912           
=======================================
+ Hits        39548    39549    +1     
+ Misses       8364     8363    -1     
Impacted Files Coverage Δ
parquet/src/encodings/encoding.rs 94.67% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 499301c...6b40e9b. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it -- thank you @novemberkilo !

@novemberkilo
Copy link
Contributor Author

@alamb should the DictionaryArray types here also receive the same treatment?

@alamb
Copy link
Contributor

alamb commented Sep 20, 2021

@alamb should the DictionaryArray types here also receive the same treatment?

Yes please @novemberkilo !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants