Refactor arrow-ipc: Rename ArrayReader to RecodeBatchDecoder
#7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 27, 2025
alamb
force-pushed
the
alamb/ipc_reader_refactor2
branch
from
d3265f6 to
4838002
Compare
alamb
commented
Jan 27, 2025
| @@ -65,7 +65,7 @@ fn read_buffer( | |||
| (false, Some(decompressor)) => decompressor.decompress_to_buffer(&buf_data), | |||
| } | |||
| } | |||
| impl ArrayReader<'_> { | |||
| impl RecordBatchDecoder<'_> { | |||
There was a problem hiding this comment.
The major change is to rename this per @tustvold 's suggestion:
| @@ -83,18 +83,17 @@ impl ArrayReader<'_> { | |||
| field: &Field, | |||
| variadic_counts: &mut VecDeque<i64>, | |||
| ) -> Result<ArrayRef, ArrowError> { | |||
| let reader = self; | |||
There was a problem hiding this comment.
removed reader alias as well
tustvold
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ArrayReader#7006Rationale for this change
I did not make these changes in #7006 to minimize the diffs
What changes are included in this PR?
RecordBatchDecoderI am working on another PRs to migrate the rest of the IPC reading code to be part of RecordBatchDecoder
Are there any user-facing changes?
No, these are crate internal structures