docs: add to bit slice iterator docs that the start value is inclusive and end value is exclusive #7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and end value is exclusive
alamb
approved these changes
Jan 27, 2025
| @@ -93,6 +93,8 @@ impl DoubleEndedIterator for BitIterator<'_> { | |||
| /// Returns `(usize, usize)` each representing an interval where the corresponding | |||
| /// bits in the provides mask are set | |||
| /// | |||
| /// the first value is the start of the range (inclusive) and the second value is the end of the range (exclusive) | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
When working on apache/datafusion#14299 I had to look through the code to understand if the end is exclusive or not
Are there any user-facing changes?
only docs