Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[53.0.0_maintenance] Update parquet-testing pin, add tests for new invalid data #6985

Merged
merged 2 commits into from
Jan 15, 2025
Merged

[53.0.0_maintenance] Update parquet-testing pin, add tests for new invalid data #6985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90fc796
Update parquet testing pin
alamb Jan 15, 2025
5b2661b
Add a test for ARROW-GH-45185.parquet
alamb Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parquet-testing
Open in desktop
Submodule parquet-testing updated 16 files
+ − bad_data/ARROW-GH-45185.parquet
+ − bad_data/ARROW-RS-GH-6229-DICTHEADER.parquet
+2 −0 bad_data/README.md
+2 −1 data/README.md
+ − data/alltypes_dictionary.parquet
+ − data/alltypes_plain.parquet
+ − data/alltypes_plain.snappy.parquet
+ − data/encrypt_columns_and_footer.parquet.encrypted
+ − data/encrypt_columns_and_footer_aad.parquet.encrypted
+ − data/encrypt_columns_and_footer_ctr.parquet.encrypted
+ − data/encrypt_columns_and_footer_disable_aad_storage.parquet.encrypted
+ − data/encrypt_columns_plaintext_footer.parquet.encrypted
+164 −0 data/map_no_value.md
+ − data/map_no_value.parquet
+ − data/nan_in_stats.parquet
+ − data/uniform_encryption.parquet.encrypted
11 changes: 11 additions & 0 deletions parquet/tests/arrow_reader/bad_data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ static KNOWN_FILES: &[&str] = &[
"ARROW-GH-43605.parquet",
"ARROW-RS-GH-6229-DICTHEADER.parquet",
"ARROW-RS-GH-6229-LEVELS.parquet",
"ARROW-GH-45185.parquet",
"README.md",
];

Expand Down Expand Up @@ -120,6 +121,16 @@ fn test_arrow_rs_gh_6229_dict_levels() {
);
}

#[test]
#[cfg(feature = "snap")]
fn test_arrow_rs_gh_45185_dict_levels() {
let err = read_file("ARROW-GH-45185.parquet").unwrap_err();
assert_eq!(
err.to_string(),
"External: Parquet argument error: Parquet error: first repetition level of batch must be 0"
);
}

/// Reads the file and tries to return the total row count
/// Returns an error if the file is invalid
fn read_file(name: &str) -> Result<usize, ParquetError> {
Expand Down
Loading