[Parquet] Add benchmark and test for writing NaNs to Parquet #6955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
parquet
alamb
approved these changes
Jan 8, 2025
CurtHagenlocher
pushed a commit
to CurtHagenlocher/arrow-rs
that referenced
this pull request
Jan 13, 2025
…6955) * Add test and benchmarks for writing floats with NaNs * Remove extra benchmark with no NaNs
svencowart
pushed a commit
to elastiflow/arrow-rs
that referenced
this pull request
Jan 14, 2025
…6955) * Add test and benchmarks for writing floats with NaNs * Remove extra benchmark with no NaNs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This doesn't close an issue but adds a benchmark that should be improved when #6952 is fixed.
Rationale for this change
Splits out the benchmark from the fix for #6952 to make it easier to compare performance, as requested in #6953 (comment)
What changes are included in this PR?
Are there any user-facing changes?
No