[Parquet] Add projection utility functions #6931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Jan 3, 2025
parquet/src/arrow/mod.rs
Outdated
Comment on lines
287
to
290
| /// Example: | ||
| /// mask1 = [true, false, true] | ||
| /// mask2 = [false, true, true] | ||
| /// union(mask1, mask2) = [true, true, true] |
There was a problem hiding this comment.
The rendered docs look.a bit off:
I pushed a commit to make them a bit nicer
Suggested change
| /// Example: | |
| /// mask1 = [true, false, true] | |
| /// mask2 = [false, true, true] | |
| /// union(mask1, mask2) = [true, true, true] | |
| /// Example: | |
| /// mask1 = [true, false, true] | |
| /// mask2 = [false, true, true] | |
| /// union(mask1, mask2) = [true, true, true] |
|
Thank you @XiangpengHao and @tustvold |
CurtHagenlocher
pushed a commit
to CurtHagenlocher/arrow-rs
that referenced
this pull request
Jan 13, 2025
* projection utilities * improve docs --------- Co-authored-by: Andrew Lamb <[email protected]>
svencowart
pushed a commit
to elastiflow/arrow-rs
that referenced
this pull request
Jan 14, 2025
* projection utilities * improve docs --------- Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #6921
Rationale for this change
To implement row level filtering for Parquet, we need to cache columns that are being filtered, i.e., the column is both in filter's predicate projection and in final output projection.
This PR adds two utility functions to union and interset two projections.
What changes are included in this PR?
Are there any user-facing changes?