arrow-ipc: Default to not preserving dict IDs #6788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The integration tests seem to be legitimately failing on this |
|
Is this the appropriate docs page to look at for trying to reproduce this locally? https://github.com/apache/arrow-rs/tree/main/arrow-integration-testing |
|
So diving in, it looks like ipc, and c-data work fine, it's just flight. And surprisingly even rust-to-rust seems broken, which is what I'm going to start with, by adding more tests to arrow-flight. |
brancz
force-pushed
the
not-preserve-default
branch
from
63a1952 to
75ceb39
Compare
Previously the integration tests forced preserving dict IDs in some places and used the default in others. This worked fine previously because preserving dict IDs used to be the default, but it isn't anymore.
brancz
force-pushed
the
not-preserve-default
branch
from
75ceb39 to
206f7f4
Compare
tustvold
approved these changes
Nov 27, 2024
alamb
approved these changes
Nov 30, 2024
|
Thank you @brancz 🙏 |
|
Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #5981
Rationale for this change
This is the first step towards removing the
dict_idfield as discussed in #5981. With this patch the default behavior changes to what the behavior will be once the field is fully removed.The previous behavior can still be restored by passing
with_preserve_dict_id(true), however, doing so is now deprecated and will be removed together with thedict_idin the next (March) DataFusion release.What changes are included in this PR?
Default to not preserving the dict ID from the schema field
dict_id.Are there any user-facing changes?
Not a breaking change to an API, but the default behavior changes.
@tustvold @alamb