Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check sign_payload instead of skip_signature before computing checksum #6698

Merged
merged 3 commits into from
Nov 8, 2024
Merged

check sign_payload instead of skip_signature before computing checksum #6698

merged 3 commits into from
Nov 8, 2024

Conversation

mherrerarendon
Copy link
Contributor

Which issue does this PR close?

Closes #6697

What changes are included in this PR?

Checks for sign_payload instead of !skip_signature before generating the payload checksum

Are there any user-facing changes?

Yes

@github-actions github-actions bot added the object-store Object Store Interface label Nov 6, 2024
@mherrerarendon @tustvold
Update object_store/src/aws/client.rs
37396fb 
Co-authored-by: Raphael Taylor-Davies <[email protected]>
@tustvold tustvold merged commit 0e9abcd into apache:master Nov 8, 2024
14 checks passed
@alamb alamb mentioned this pull request Nov 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrebsguedes andrebsguedes andrebsguedes left review comments

@tustvold tustvold Awaiting requested review from tustvold

Assignees
No one assigned
Labels
object-store Object Store Interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

with_unsigned_payload shouldn't generate payload hash
3 participants
@mherrerarendon @tustvold @andrebsguedes