Add Array::with_nulls #6659
Closed
Add Array::with_nulls #6659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Oct 31, 2024
| /// | ||
| /// # Example: | ||
| /// ``` | ||
| /// # use arrow_array::{Array, Int32Array}; |
There was a problem hiding this comment.
Here is the new API and an example. I am not sure this is a good idea due to @tustvold 's comment here: #6528 (comment) but figured I would make a PR for discussion (and only now do I really understand what he is talking about)
| /// let array_with_nulls = array.with_nulls(nulls); | ||
| /// assert_eq!( | ||
| /// array_with_nulls.as_primitive(), | ||
| /// &Int32Array::from(vec![None, Some(0), None, Some(4), None]), |
There was a problem hiding this comment.
the fact that this is now Some(0) (whatever value was created for the null element in the original array) could have potential issues 🤔
tustvold
requested changes
Oct 31, 2024
|
I agree -- let's not do this. I have another idea that might help #6528 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6528
Rationale for this change
Propose adding a new safe API to replace nulls
@tustvold mentioned the potential implications of this API #6528 (comment) here. I added an example to show what was going on
What changes are included in this PR?
Add
Array::with_nullsAre there any user-facing changes?
New API