Fix test feature selection so all feature combinations work as expected #6626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etseidl
approved these changes
Oct 25, 2024
| @@ -31,7 +31,7 @@ use crate::schema::types; | |||
| use crate::schema::types::SchemaDescriptor; | |||
| use crate::thrift::{TCompactSliceInputProtocol, TSerializable}; | |||
|
|
|||
| #[cfg(feature = "async")] | |||
| #[cfg(all(feature = "async", feature = "arrow"))] | |||
There was a problem hiding this comment.
Thanks, nice catch! It seems I relied on the default feature set when I added this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Some combinations of features cause compilation failures or test failures where not necessary. For example, in the
parquet/src/file/metadata/reader.rsfile, theMetadataFetchtrait is only imported whenfeature = "async", but that trait exists under a module that's markedfeature = "arrow", so we need to enable both those features to get it to work.Rationale for this change
There's nothing stopping people from using any combination of features from this crate, so we should make sure they're all supported
What changes are included in this PR?
This just adds extra
#[cfg()]attributes where necessary to fix compilation and test failures.Are there any user-facing changes?
No. It looks, on the surface, like we could be breaking the parquet crate for people who have the
asyncflag enabled with thearrowflag disabled, but this crate doesn't compile in its current form for that combination, so this won't actually adversely affect anyone.