Added casting from Binary/LargeBinary to Utf8View #6592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Oct 21, 2024
arrow-cast/src/cast/mod.rs
Outdated
| Utf8View => { | ||
| let array = cast_binary_to_string::<i64>(array, cast_options)?; | ||
| Ok(Arc::new(StringViewArray::from( | ||
| cast_byte_container::<LargeUtf8Type, Utf8Type>(array.as_ref())? |
There was a problem hiding this comment.
I think this could result in offset overflow, is this cast required?
There was a problem hiding this comment.
I played around with this and found that StringViewArray::from works directly from a LargeStringArray and pushed a commit I think helps.
There was a problem hiding this comment.
I also made a PR to help document #6610
alamb
approved these changes
Oct 21, 2024
arrow-cast/src/cast/mod.rs
Outdated
| Utf8View => { | ||
| let array = cast_binary_to_string::<i64>(array, cast_options)?; | ||
| Ok(Arc::new(StringViewArray::from( | ||
| cast_byte_container::<LargeUtf8Type, Utf8Type>(array.as_ref())? |
There was a problem hiding this comment.
I played around with this and found that StringViewArray::from works directly from a LargeStringArray and pushed a commit I think helps.
| assert!(can_cast_types( | ||
| binary_array.data_type(), | ||
| &DataType::BinaryView | ||
| )); | ||
|
|
||
| let string_view_array = cast(&binary_array, &DataType::Utf8View).unwrap(); |
There was a problem hiding this comment.
I double checked that this is invoked with both BinaryArray and LargeBinaryArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6531.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?