Added PartialOrd for FixedSizeListArray (and struct members) #6393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d derived PartialOrd for BooleanBuffer, NullBuffer, and FixedSizeListArray.
ngli-me
changed the title
|
This won't derive an implementation of PartialOrd that has any real meaning, for example nulls won't behave in a sensible manner. I think datafusion should instead use the logic already in arrow-ord for this, I'm not sure PartialOrd on the arrays is the way to achieve this |
|
Ah, I didn't even realize that existed, that's my bad. Sorry I'm newer to these projects, just been poking around. In that case, yeah this is not needed, I'll close it out. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related apache/datafusion#8932.
Rationale for this change
Allows upstream users of FixedSizeListArray, such as DataFusion, to use derived PartialOrd.
What changes are included in this PR?
Added PartialOrd implementation for Array, ArrayData and Buffer.
Added derived PartialOrd for BooleanBuffer, NullBuffer, and FixedSizeListArray.
Are there any user-facing changes?
FixedSizeListArray and its subtypes will have PartialOrd available.