parquet writer: Raise an error when the row_group_index overflows i16 #6378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
changed the title
progval
force-pushed
the
row-group-overflow
branch
from
2d17183 to
740f1e4
Compare
This caused confusing panics down the line because 'ordinal' is negative.
progval
force-pushed
the
row-group-overflow
branch
from
740f1e4 to
7dba46d
Compare
|
Nice catch! |
This was referenced Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This caused confusing panics down the line because 'ordinal' is negative.
This is easy to reach, because Parquet requires ordinals to be
i16, which only allows 32k row groups.What changes are included in this PR?
Adds an overflow check when casting
usizetoi16; and an extra check when incrementing theusizefor good measure (though it should never happen)Are there any user-facing changes?
new error message