object_store/delimited: Fix TrailingEscape condition
#6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
reviewed
Aug 20, 2024
| @@ -126,7 +126,7 @@ impl LineDelimiter { | |||
| fn finish(&mut self) -> Result<bool> { | |||
| if !self.remainder.is_empty() { | |||
| ensure!(!self.is_quote, UnterminatedStringSnafu); | |||
| ensure!(!self.is_quote, TrailingEscapeSnafu); | |||
| ensure!(!self.is_escape, TrailingEscapeSnafu); | |||
There was a problem hiding this comment.
Is this covered by a test? If not, could you add one?
There was a problem hiding this comment.
Is this covered by a test?
I assume not, since I didn't have to adjust any tests 😅
If not, could you add one?
unfortunately I don't think I'm familiar enough with the code to be able to write such a test :-/
This seems like a copy-paste mistake since checking `is_quote` twice is probably wrong...
|
/cc @tustvold :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a copy-paste mistake since checking
is_quotetwice is probably wrong...