Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ipc): reencode list offsets bug #5808

Closed

Conversation

JasonLi-cn
Copy link
Contributor

@JasonLi-cn JasonLi-cn commented May 28, 2024

Which issue does this PR close?

Closes #5809

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label May 28, 2024
@tustvold
Copy link
Contributor

Can we get a test please

@JasonLi-cn
Copy link
Contributor Author

Can we get a test please

The example adds to the issue: #5809

@JasonLi-cn
Copy link
Contributor Author

From the "Archery test With other arrows" results, it appears that java arrow was unable to decode the Rust String ListArray after fixing the bug. 🤔

@JasonLi-cn
Copy link
Contributor Author

Can we get a test please

The example adds to the issue: #5809

@tustvold please review

@tustvold
Copy link
Contributor

Your comment appeared to imply Java can't handle this currently in which case we shouldn't do this just yet.

Additionally can we get the test added to the test suite, otherwise there is nothing to prevent regressions

@alamb
Copy link
Contributor

alamb commented Jun 17, 2024

Possibly related to #5895

@alamb alamb marked this pull request as draft July 1, 2024 19:18
@alamb
Copy link
Contributor

alamb commented Jul 1, 2024

Marking as a draft as this PR appears not to be waiting on feedback. Please mark it as ready for review when it is ready for another look

@tustvold
Copy link
Contributor

tustvold commented Oct 8, 2024

Closing as this PR has been inactive for a while

@tustvold tustvold closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-Encode Offsets When Writing ListArray to IPC
3 participants