Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labeller attempt 2 #5174

Merged
merged 1 commit into from
Dec 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 29 additions & 10 deletions .github/workflows/dev_pr/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,40 @@
# under the License.

arrow:
- changed-files:
- any-glob-to-any-file: ['arrow-arith/**/*', 'arrow-array/**/*', 'arrow-buffer/**/*', 'arrow-cast/**/*', 'arrow-csv/**/*', 'arrow-data/**/*', 'arrow-flight/**/*', 'arrow-integration-test/**/*', 'arrow-integration-testing/**/*', 'arrow-ipc/**/*', 'arrow-json/**/*', 'arrow-avro/**/*', 'arrow-ord/**/*', 'arrow-row/**/*', 'arrow-schema/**/*', 'arrow-select/**/*', 'arrow-string/**/*', 'arrow/**/*']
- changed-files:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this indent is important

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I wrote it as following their doc. Maybe both work? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was still seeing failures after I had merged your change, so I don't know - https://github.com/apache/arrow-rs/actions/runs/7108966498/job/19353153089

Either way we seem to be in the clear now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I'm just wondering why it still had failures. But nvm as it works now. 😄

- any-glob-to-any-file:
- 'arrow-arith/**/*'
- 'arrow-array/**/*'
- 'arrow-buffer/**/*'
- 'arrow-cast/**/*'
- 'arrow-csv/**/*'
- 'arrow-data/**/*'
- 'arrow-flight/**/*'
- 'arrow-integration-test/**/*'
- 'arrow-integration-testing/**/*'
- 'arrow-ipc/**/*'
- 'arrow-json/**/*'
- 'arrow-avro/**/*'
- 'arrow-ord/**/*'
- 'arrow-row/**/*'
- 'arrow-schema/**/*'
- 'arrow-select/**/*'
- 'arrow-string/**/*'
- 'arrow/**/*'

arrow-flight:
- changed-files:
- any-glob-to-any-file: ['arrow-flight/**/*']
- changed-files:
- any-glob-to-any-file:
- 'arrow-flight/**/*'

parquet:
- changed-files:
- any-glob-to-any-file: ['parquet/**/*']
- changed-files:
- any-glob-to-any-file: [ 'parquet/**/*' ]

parquet-derive:
- changed-files:
- any-glob-to-any-file: ['parquet_derive/**/*']
- changed-files:
- any-glob-to-any-file: [ 'parquet_derive/**/*' ]

object-store:
- changed-files:
- any-glob-to-any-file: ['object_store/**/*']
- changed-files:
- any-glob-to-any-file: [ 'object_store/**/*' ]
Loading