Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update comment on sort_to_indices to reflect correct ordering #5033

Merged

Conversation

westonpace
Copy link
Member

Which issue does this PR close?

Closes #5029.

Rationale for this change

The documentation was incorrect. Floats are sorted using total order.

What changes are included in this PR?

The doc comment is updated to reflect reality.

Are there any user-facing changes?

No, the change is comment/doc only

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 2, 2023
@tustvold tustvold merged commit a447bcf into apache:master Nov 2, 2023
16 checks passed
@tustvold
Copy link
Contributor

tustvold commented Nov 2, 2023

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect comment on arrow::compute::kernels::sort::sort_to_indices
2 participants