Add ObjectMeta::version and GetOptions::version (#4925) #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
approved these changes
Oct 16, 2023
| @@ -145,6 +145,7 @@ impl ObjectStore for InMemory { | |||
| last_modified, | |||
| size: data.len(), | |||
| e_tag: None, | |||
| version: None, | |||
There was a problem hiding this comment.
In theory the mem backend could implement this, not sure if that would be helpful for testing (might also be a follow-up PR).
BTW: what's the expectation regarding how long versions are kept in "the cloud"?
There was a problem hiding this comment.
Indeed this is waiting on #4922
As for expectations, none, we expose what is in the store, which in turn will depend on what lifecycle policy has been configured if any
|
The use-case I thought I had for this, can actually avoid needing this complexity, so parking this as a draft whilst I reflect on this |
jacksonrnewhouse
added a commit
to ArroyoSystems/arrow-rs
that referenced
this pull request
Oct 23, 2023
…apache#4935)" This reverts commit f4a2a88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4925
Rationale for this change
This adds the ability to get the version of an object
What changes are included in this PR?
Are there any user-facing changes?