Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return error when converting schema #4752

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

wjones127
Copy link
Member

Which issue does this PR close?

Closes #4750.

Rationale for this change

Some implementations allow invalid utf-8 sequences in metadata, so we should return an error when importing.

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 30, 2023
@wjones127 wjones127 marked this pull request as ready for review August 30, 2023 03:57
@wjones127 wjones127 requested a review from alamb August 30, 2023 03:57
Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@tustvold tustvold merged commit 735f48d into apache:master Aug 30, 2023
@wjones127 wjones127 deleted the 4750-stream-schema-panic branch August 30, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate bug python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream ffi panics if schema metadata values aren't valid utf8
3 participants