Implement PyArrowType for Box<dyn RecordBatchReader + Send>
#4751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
approved these changes
Aug 30, 2023
tustvold
reviewed
Aug 30, 2023
arrow/src/pyarrow.rs
Outdated
| @@ -277,10 +278,19 @@ impl FromPyArrow for ArrowArrayStreamReader { | |||
| } | |||
| } | |||
|
|
|||
| impl IntoPyArrow for ArrowArrayStreamReader { | |||
| impl FromPyArrow for Box<dyn RecordBatchReader + Send> { | |||
There was a problem hiding this comment.
What is the advantage of this over just using ArrowArrayStreamReader directly?
As an aside we should probably document this method better, it isn't immediately clear it can be passed a pyarrow RecordBatchReader
There was a problem hiding this comment.
TBH I wouldn't have implemented FromPyArrow if it weren't required by PyArrowType. But you need to implement both IntoPyArrow and FromPyArrow in order to get PyArrowType.
There was a problem hiding this comment.
Hmm... Perhaps we can relax those constraints 🤔
There was a problem hiding this comment.
Created #4757 which I think would remove the need for this
wjones127
force-pushed
the
4730-pyarrowtype-rbr
branch
from
8675826 to
656ac57
Compare
tustvold
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4730.
I couldn't get it to work for a generic RBR, but it needs to be boxed anyways.
Rationale for this change
Saves the user the step of creating an
ArrowArrayStreamReaderwhen exporting a record batch reader.What changes are included in this PR?
Are there any user-facing changes?