Update error variant IoError to include the underlying I/O error
#4723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror` and fix some errors semantics
github-actions
bot
added
arrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Does not close any open issue.
Rationale for this change
I need to handle some kind of I/O errors (notably broken pipe errors) specifically and the current
IoErrorvariant does not permit it because it does not expose the underlyingstd::io::Error.What changes are included in this PR?
std::io::Errorfield toIoErrorvariantIoErrorwithin the IPC module (the only place where it's used)I'm not 100% sure about the new semantics of errors in the IPC module so feel to correct me.
Are there any user-facing changes?
Yes. Callers that handle
IoErrorseparately will need to update their patterns to include the new field.