Cleanup length and bit_length kernels #4718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Aug 23, 2023
| nulls: Option<&NullBuffer>, | ||
| ) -> ArrayRef { | ||
| let v: Vec<_> = offsets | ||
| .windows(2) |
| let list = array.as_binary::<i64>(); | ||
| Ok(bit_length_impl::<Int64Type>(list.offsets(), list.nulls())) | ||
| } | ||
| DataType::FixedSizeBinary(len) => Ok(Arc::new(Int32Array::new( |
There was a problem hiding this comment.
the support for FixedSizeBinary seems to be new here but there is no test update -- maybe we can add a test for it?
arrow-string/src/length.rs
Outdated
| other => Err(ArrowError::ComputeError(format!( | ||
| "bit_length not supported for {other:?}" | ||
| "length not supported for {other:?}" |
There was a problem hiding this comment.
I think the prior message was correct as this is the bit_length implementation 🤔
There was a problem hiding this comment.
Yeah this was a copypasta
Dandandan
reviewed
Aug 23, 2023
arrow-string/src/length.rs
Outdated
| other => Err(ArrowError::ComputeError(format!( | ||
| "bit_length not supported for {other:?}" | ||
| "length not supported for {other:?}" |
There was a problem hiding this comment.
Suggested change
| "length not supported for {other:?}" | |
| "bit_length not supported for {other:?}" |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?