Cleanup cast_primitive_to_list #4511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Jul 12, 2023
| to_type.clone(), | ||
| array.len(), | ||
| Some(cast_array.null_count()), | ||
| cast_array.nulls().map(|b| b.inner().sliced()), |
There was a problem hiding this comment.
There is no reason to duplicate the null buffer here, so I opted to just remove this. I can easily revert if people feel it is better to include the child null mask twice
tustvold
commented
Jul 12, 2023
| @@ -9448,4 +9420,21 @@ mod tests { | |||
| assert_eq!("1969-12-31", string_array.value(1)); | |||
| assert_eq!("1989-12-31", string_array.value(2)); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_nested_list() { | |||
There was a problem hiding this comment.
This is not new functionality, I just couldn't find a test of it
alamb
approved these changes
Jul 12, 2023
| @@ -5098,7 +5070,7 @@ mod tests { | |||
| ) | |||
| .unwrap(); | |||
| assert_eq!(5, b.len()); | |||
| assert_eq!(1, b.null_count()); | |||
| assert_eq!(0, b.null_count()); | |||
There was a problem hiding this comment.
Is the difference that b[1] is [null] (aka a 1 element list with a null) rather than null itself? I believe that is already covered below.
arrow-cast/src/cast.rs
Outdated
| fn test_nested_list() { | ||
| let mut list = ListBuilder::new(Int32Builder::new()); | ||
| list.append_value([Some(1), Some(2), Some(3)]); | ||
| list.append_value([Some(4), Some(5), Some(6)]); |
There was a problem hiding this comment.
Can we please include a NULL in the list -- for example,
Suggested change
| list.append_value([Some(4), Some(5), Some(6)]); | |
| list.append_value([Some(4), Null, Some(6)]); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?