Add default implementations to the FlightSqlService trait #4485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
xudong963
approved these changes
Jul 8, 2023
rossjones
force-pushed
the
default-flightsqlservice-implementations
branch
from
91b0968 to
7935cf9
Compare
The trait currently does not have many default implementations, but it does have a lot of methods. This PR adds default implementations for all methods returning Status::unimplemented to fix apache#4372
rossjones
force-pushed
the
default-flightsqlservice-implementations
branch
from
7935cf9 to
e78575a
Compare
Thanks, should be done now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4372
Rationale for this change
This trait is on the large side, and requires lots of boilerplate to implement. It would benefit from default implementations of all methods.
What changes are included in this PR?
Adds default implementations for all methods of FlightSqlService so they now return Status::unimplemented along with a description of " has no default implementation" following the wording in other methods that do have a default impl.
Are there any user-facing changes?