feat: support RecordBatchReader on boxed trait objects #4475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
commented
Jul 2, 2023
| @@ -157,7 +157,7 @@ impl Drop for FFI_ArrowArrayStream { | |||
|
|
|||
| impl FFI_ArrowArrayStream { | |||
| /// Creates a new [`FFI_ArrowArrayStream`]. | |||
| pub fn new(batch_reader: Box<dyn RecordBatchReader>) -> Self { | |||
| pub fn new(batch_reader: Box<dyn RecordBatchReader + Send>) -> Self { | |||
There was a problem hiding this comment.
This is sort of a bug fix to get in compliant with the released API, but in a direct sense it is breaking, so maybe this should be labelled as breaking change? Not sure 🤔
tustvold
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4474.
This also contains a drive-by change to make the FFI export require Send, since we implemented send for the FFI struct earlier in #4232.
Rationale for this change
Makes it possible to take generic
impl RecordBatchReaderarguments that support boxed and unboxed ones.What changes are included in this PR?
Are there any user-facing changes?