Add support for FixedSizeList in array_to_json_array #4361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
reviewed
Jun 4, 2023
arrow-json/src/writer.rs
Outdated
| @@ -190,6 +190,15 @@ pub fn array_to_json_array(array: &ArrayRef) -> Result<Vec<Value>, ArrowError> { | |||
| None => Ok(Value::Null), | |||
| }) | |||
| .collect(), | |||
| DataType::FixedSizeList(_, _) => { | |||
| ListArray::from(as_fixed_size_list_array(array).to_owned()) | |||
There was a problem hiding this comment.
You should be able to use ArrayIter directly without needing to convert to a ListArray. Could probably add iter() to FixedSizeListArray also to make this more discoverable...
There was a problem hiding this comment.
Updated as suggested. Including adding iter() to FixedSizeListArray
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4248
What changes are included in this PR?
Makes use of the ability to convert
FixedSizeListtoListArrayintroduced in this PR #4273 to enablearray_to_json_arrayto now support converting FixedSizeList`.Are there any user-facing changes?
No, although the function
array_to_json_arraygains ability to work with one more array type