Simplify ObjectStore configuration pattern #4189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
May 9, 2023
| @@ -742,18 +727,28 @@ impl AmazonS3Builder { | |||
| AmazonS3ConfigKey::UnsignedPayload => { | |||
| self.unsigned_payload = str_is_truthy(&value.into()) | |||
| } | |||
| AmazonS3ConfigKey::Checksum => { | |||
| let algorithm = Checksum::try_from(&value.into()) | |||
| .map_err(|_| Error::InvalidChecksumAlgorithm)?; | |||
There was a problem hiding this comment.
This was problematic as this error would get unwrapped in from_env
There was a problem hiding this comment.
This is fixed properly in #4192
|
@roeap perhaps you might be able to give this a look? |
roeap
approved these changes
May 10, 2023
|
Thank you for the prompt review 💪
#4192 should be ready for review now, it currently only defers the parsing of values, and so the key arguments are still typed. I personally think this is more idiomatic, and allows users to choose how to handle unexpected keys, but appreciate opinions may differ. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Relates to #4047
Rationale for this change
Originally added in #3436 by @roeap, the API can be made simpler and easier to use
What changes are included in this PR?
Are there any user-facing changes?
This makes the config enumerations non exhaustive, so that options can be added without it being a breaking change