Remove Type from NativeIndex #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
remove-type-native-index
branch
from
32bb94f to
d0947c2
Compare
tustvold
commented
Apr 27, 2023
| @@ -118,11 +116,10 @@ pub struct NativeIndex<T: ParquetValueType> { | |||
| } | |||
|
|
|||
| impl<T: ParquetValueType> NativeIndex<T> { | |||
| pub const PHYSICAL_TYPE: Type = T::PHYSICAL_TYPE; | |||
There was a problem hiding this comment.
This is necessary because ParquetValueType is technically an experimental API
viirya
reviewed
Apr 27, 2023
parquet/src/file/page_index/index.rs
Outdated
| @@ -106,8 +106,6 @@ impl Index { | |||
| /// Stores the [`PageIndex`] for each page of a column with [`Type`] | |||
There was a problem hiding this comment.
Do we need to update the doc for the [Type]?
There was a problem hiding this comment.
What did you have in mind?
There was a problem hiding this comment.
I meant do we need to remove it?
viirya
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Follow up to #3578 that switches
FIXED_LEN_BYTE_ARRAYto useFixedLenByteArraywhich in turn allows removingTypefromNativeIndexWhat changes are included in this PR?
Are there any user-facing changes?