feat: support Interval + Timestamp and Interval + Date
#4117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Timestamp + Interval and Interval + Date
tustvold
reviewed
Apr 24, 2023
arrow-arith/src/arithmetic.rs
Outdated
|
|
||
| DataType::Interval(_) | ||
| if right.data_type().is_temporal() | ||
| && left.data_type() != right.data_type() => |
There was a problem hiding this comment.
I think this will recurse indefinitely if given two interval types with different IntervalUnit
Perhaps we could just explicitly match DataType::Timestamp | DataType::Date32 | DataType::Date32? Longer-term I hope to clean this all up as part of #3999
There was a problem hiding this comment.
I believe that the trait-based approach is a superior method for long-term maintenance. 👍
tustvold
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4094
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?