Add ByteArray constructors (#3879) #4081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
add-byte-array-constructors
branch
from
4c007c0 to
0d2ce17
Compare
tustvold
force-pushed
the
add-byte-array-constructors
branch
from
7a9bf3a to
db5b485
Compare
viirya
reviewed
Apr 18, 2023
Comment on lines
+1616
to
+1617
| "Maximum offset of {max_offset} is larger than values of length {}", | ||
| values.len() |
There was a problem hiding this comment.
Suggested change
| "Maximum offset of {max_offset} is larger than values of length {}", | |
| values.len() | |
| "Maximum offset of {max_offset} is larger than length of values {}", | |
| values.len() |
There was a problem hiding this comment.
I think the phrasing before is grammatically more correct
viirya
reviewed
Apr 18, 2023
| T::validate(&offsets, &values)?; | ||
|
|
||
| if let Some(n) = nulls.as_ref() { | ||
| if n.len() != len { |
There was a problem hiding this comment.
Don't we need to also check the length of values buffer?
There was a problem hiding this comment.
This is covered by T::validate, will add a comment
viirya
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3879
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?