Relax JSON schema inference generics #4063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Apr 14, 2023
| @@ -265,8 +265,8 @@ pub fn infer_json_schema_from_seekable<R: Read + Seek>( | |||
| /// // seek back to start so that the original file is usable again | |||
| /// file.seek(SeekFrom::Start(0)).unwrap(); | |||
| /// ``` | |||
| pub fn infer_json_schema<R: Read>( | |||
| reader: &mut BufReader<R>, | |||
| pub fn infer_json_schema<R: BufRead>( | |||
There was a problem hiding this comment.
The idea here is that any existing user of this API will be fine because a &mut BufReader<R> also implements BufRead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
Noticed whilst working on #4052, requiring
&mut BufReaderis unnecessarily restrictiveWhat changes are included in this PR?
Are there any user-facing changes?