Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: add tests for BooleanBuffer #4004

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Minor: add tests for BooleanBuffer #4004

merged 2 commits into from
Apr 3, 2023

Conversation

izveigor
Copy link
Contributor

@izveigor izveigor commented Apr 3, 2023

Which issue does this PR close?

Minor change: add some tests for BooleanBuffer.

Rationale for this change

There are no basic tests for BooleanBuffer.

What changes are included in this PR?

The next tests:

  • test_boolean_new (check methods: new, values, offset, len, count_set_bits, inner, into_inner)
  • test_boolean_data_equality
  • test_boolean_slice

Using the naming convention for tests of bitwise operations.

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Apr 3, 2023
@tustvold tustvold merged commit 533e983 into apache:master Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izveigor @tustvold