Convert string_to_timestamp_nanos to doctest #3978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Mar 30, 2023
| @@ -264,8 +264,17 @@ pub fn string_to_datetime<T: TimeZone>( | |||
| /// This function interprets string without an explicit time zone as timestamps | |||
| /// relative to UTC, see [`string_to_datetime`] for alternative semantics | |||
| /// | |||
| /// For example, both `1997-01-31 09:26:56.123Z`, `1997-01-31T09:26:56.123`, | |||
| /// and `1997-01-31T14:26:56.123+05:00` will be parsed as the same value | |||
| /// In particular: | |||
Co-authored-by: Andrew Lamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
As by @byteink in #3977 these docs were previously wrong. This PR converts them to a doctest to guarantee correctness going forward.
What changes are included in this PR?
Are there any user-facing changes?