Add typed buffers to UnionArray (#3880) #3933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Mar 24, 2023
| if self.is_dense() { | ||
| self.data().buffers()[1].typed_data::<i32>()[self.offset() + index] | ||
| } else { | ||
| (self.offset() + index) as i32 |
There was a problem hiding this comment.
This can potentially overflow, so I opted to change value_offset to return usize as this is not only more correct, but is what most call-sites want anyway
|
I'll review this today. |
viirya
approved these changes
Mar 29, 2023
| for (i, id) in expected_type_ids.iter().enumerate() { | ||
| assert_eq!(id, &array.type_id(i)); | ||
| } | ||
|
|
||
| // Check offsets, sparse union should only have a single buffer, i.e. no offsets | ||
| assert_eq!(array.data().buffers().len(), 1); |
viirya
reviewed
Mar 29, 2023
Co-authored-by: Liang-Chi Hsieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #3880
Rationale for this change
It currently isn't possible to interact with a UnionArray's buffers in a type-safe way. This is at odds with the other array types, and causes issues migrating away from storing ArrayData under arrays.
What changes are included in this PR?
Are there any user-facing changes?
This changes the return type of UnionArray::value_offset to be correct