Fix pyarrow memory leak (#3683) #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
fix-pyarrow-memory-leak
branch
2 times, most recently
from
d2b50c4 to
8573b38
Compare
Remove ArrowArray::into_raw and try_from_raw
tustvold
force-pushed
the
fix-pyarrow-memory-leak
branch
from
8573b38 to
9028daa
Compare
tustvold
commented
Mar 21, 2023
| @@ -118,9 +118,6 @@ struct ArrayPrivateData { | |||
|
|
|||
| impl FFI_ArrowArray { | |||
| /// creates a new `FFI_ArrowArray` from existing data. | |||
| /// # Memory Leaks | |||
There was a problem hiding this comment.
This comment is out-of-date, FFI_ArrowArray frees memory automatically on drop
There was a problem hiding this comment.
I guess that it means that consumer of FFI_ArrowArray (might be in other language like JVM) should call release as C Data Interface defines to release it?
There was a problem hiding this comment.
Perhaps, but from the context of Rust it is just a little bit confusing, as release isn't even publicly visible 😅
tustvold
commented
Mar 21, 2023
| @@ -66,6 +51,7 @@ pub unsafe fn make_array_from_raw( | |||
| /// This function copies the content of two FFI structs [ffi::FFI_ArrowArray] and | |||
| /// [ffi::FFI_ArrowSchema] in the array to the location pointed by the raw pointers. | |||
| /// Usually the raw pointers are provided by the array data consumer. | |||
| #[deprecated(note = "Use FFI_ArrowArray::new and FFI_ArrowSchema::try_from")] | |||
There was a problem hiding this comment.
The above methods are not only safe, but less likely to accidentally leak memory
viirya
approved these changes
Mar 21, 2023
spebern
pushed a commit
to spebern/arrow-rs
that referenced
this pull request
Mar 25, 2023
* Fix pyarrow memory leak (apache#3683) Remove ArrowArray::into_raw and try_from_raw * Update docs * Further deprecation * Clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #3683
Rationale for this change
This is a follow on to #3685 that removes the deprecated methods, and fixes a remaining memory leak.
What changes are included in this PR?
Are there any user-facing changes?