Rework Strongly Typed ArrayData Abstractions #3877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Mar 16, 2023
| /// 2: the values | ||
| /// | ||
| /// We store an array so that a slice can be returned in [`RunArrayData::layout`] | ||
| children: Box<[ArrayData; 2]>, |
There was a problem hiding this comment.
We no longer need this hack 🎉
tustvold
commented
Mar 16, 2023
| /// ArrayData for [dictionary arrays](https://arrow.apache.org/docs/format/Columnar.html#dictionary-encoded-layout) | ||
| #[derive(Debug, Clone)] | ||
| pub struct DictionaryArrayData<K: DictionaryKey> { | ||
| data_type: DataType, | ||
| nulls: Option<NullBuffer>, | ||
| keys: ScalarBuffer<K>, | ||
| values: Box<ArrayData>, | ||
| values: ArrayData, |
There was a problem hiding this comment.
We no longer need to Box children, as not intending to use within an ArrayData enumeration
|
Realised these need to check the DataType when converting from ArrayData, will fix tomorrow |
tustvold
force-pushed
the
typed-array-data
branch
from
6fb8c36 to
805f527
Compare
|
Thinking about this a bit more, it is unclear what value add these abstractions have over the existing arrays... There may be more simplification possible... 🤔 |
|
Closing in favor of #3880 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #1799
Rationale for this change
See #1799 (comment)
In particular:
from_rawtoFrom<ArrayData>layouttoFrom<_> for ArrayDataArrayDataLayoutWhat changes are included in this PR?
Are there any user-facing changes?